Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(codegen): better error messages for internals using module.exports #15687

Merged
merged 2 commits into from
Dec 10, 2024
Merged

fix(codegen): better error messages for internals using module.exports #15687

merged 2 commits into from
Dec 10, 2024
+12 −2

Conversation

DonIsaac
Copy link
Contributor

What does this PR do?

Ensures internal modules have a default export. Before this, codegen would pass but compilation would fail further along in the process.

How did you verify your code works?

This is a codegen change that does not affect output code. If this builds, it works.

@DonIsaac DonIsaac requested a review from paperdave December 10, 2024 21:42
@robobun
Copy link

robobun commented Dec 10, 2024 •
edited
Loading

❌ Your commit 4778da9 has 16 failures in #7717:

  • test/js/bun/spawn/spawn.test.ts - 1 failing on 🐧 20.04 x64-baseline
  • test/js/node/test/parallel/test-worker-process-exit-async-module.js - code 1 on 🐧 3.20 x64-baseline
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 aarch64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64-baseline
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64
  • test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 24.04 aarch64
  • test/js/node/test/parallel/test-zlib-dictionary.js - code 1 on 🐧 22.04 x64-baseline
  • test/js/node/test/parallel/test-zlib-dictionary.js - code 1 on 🐧 3.20 aarch64
  • test/js/node/test/parallel/test-zlib-dictionary.js - code 1 on 🐧 3.20 x64-baseline
  • test/js/node/test/parallel/test-zlib-dictionary.js - code 1 on 🐧 3.20 x64
  • test/cli/install/bun-link.test.ts - 1 failing on 🐧 3.20 aarch64
  • test/js/deno/performance/performance.test.ts - 1 failing on 🐧 24.04 x64-baseline
  • test/js/node/fs/fs.test.ts - timeout on 🪟 2019 x64-baseline
  • test/js/bun/css/doesnt_crash.test.ts - 1 failing on 🐧 12 aarch64
  • test/js/bun/css/doesnt_crash.test.ts - timeout on 🐧 20.04 aarch64
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 12 aarch64
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 12 x64
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 12 x64-baseline
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 3.20 aarch64
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 3.20 x64-baseline
  • test/js/node/test/parallel/test-net-sync-cork.js - code 1 on 🐧 3.20 x64
  • test/bundler/bundler_compile.test.ts - 1 failing on 🐧 20.04 aarch64
  • test/js/bun/shell/bunshell.test.ts - code STATUS_SEVERITY_ERROR on 🪟 2019 x64-baseline
  • test/js/node/test/parallel/test-event-emitter-method-names.js - code 1 on 🪟 2019 x64
  • test/js/node/test/parallel/test-event-emitter-method-names.js - code 1 on 🪟 2019 x64-baseline
  • test/js/web/abort/abort.test.ts - internal assertion failure on 🪟 2019 x64-baseline
  • test/js/node/test/parallel/test-fs-readfile-flags.js - code 1 on 🪟 2019 x64
  • test/js/node/test/parallel/test-fs-readfile-flags.js - code 1 on 🪟 2019 x64-baseline
  • test/js/node/test/parallel/test-fs-watch-file-enoent-after-deletion.js - internal assertion failure on 🪟 2019 x64
  • test/js/node/test/parallel/test-fs-watch-file-enoent-after-deletion.js - internal assertion failure on 🪟 2019 x64-baseline
    		•

    paperdave
    paperdave approved these changes Dec 10, 2024
    View reviewed changes
    Copy link
    Member

    @paperdave paperdave left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    nice

    @DonIsaac DonIsaac merged commit 2d5ea49 into main Dec 10, 2024
    61 checks passed
    @DonIsaac DonIsaac deleted the don/fix/bundle-codegen-cjs-warning branch December 10, 2024 23:10
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @paperdave paperdave paperdave approved these changes

    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.
    3 participants
    @DonIsaac @robobun @paperdave